Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revive issue auto closer #4116

Merged
merged 5 commits into from
Apr 9, 2023
Merged

Revive issue auto closer #4116

merged 5 commits into from
Apr 9, 2023

Conversation

ashie
Copy link
Member

@ashie ashie commented Mar 29, 2023 •
edited
Loading

Which issue(s) this PR fixes:
N/A

What this PR does / why we need it:
Although issue auto closer is disabled at d005002 without discussion, I think we still need it at least for waiting-for-users and stable labels.

We need to revive it and tune which issues should be closed automatically.

Docs Changes:
None.

Release Note:
None.

ashie added 3 commits March 29, 2023 14:34
@ashie
Revert "Stop GitHub Actions from closing tickets"
8941f92 
This reverts commit d005002.

Signed-off-by: Takuro Ashie <[email protected]>
@ashie
Remove auto closer for issues that don't follow template
5846a07 
For opening normal issues we use issue form for now instead of template
so that users no longer able to neglect the issue template. For this
purpose auto closer isn't needed anymore.
In addition fluentd maintainers might open issues which doesn't
follow the template via other systems such as GitHub Projects.

Signed-off-by: Takuro Ashie <[email protected]>
@ashie
GHA: Update stale action to v8
1129f9f 
Signed-off-by: Takuro Ashie <[email protected]>
@ashie
Copy link
Member Author

ashie commented Mar 29, 2023

As I described in 5846a07 I think roots/issue-closer-action isn't needed in any way.

@ashie
Copy link
Member Author

ashie commented Mar 29, 2023

Untriaged issues should be closed automatically.
We should tune it in this PR.

@daipom
Copy link
Contributor

daipom commented Mar 29, 2023 •
edited
Loading

I basically agree.

I have a question about automatically staling or closing items that are not labeled at all, but I think it is a good idea to automatically stale and close items that are labeled with waiting-for-users, for example.

Even if we don't decide in detail now, we can tune these things later.

@ashie
Copy link
Member Author

ashie commented Mar 29, 2023

I introduced waiting-for-triage to fluent-plugin-kafka repository for this purpose:
fluent/fluent-plugin-kafka@85538f6

@daipom
Copy link
Contributor

daipom commented Mar 29, 2023

In fluent-plugin-remote_syslog, automatically staling and closing issues with answered label as follows.

https://github.com/fluent-plugins-nursery/fluent-plugin-remote_syslog/blob/master/.github/workflows/close-answered-issues.yml

@daipom
Copy link
Contributor

daipom commented Mar 29, 2023

I introduced waiting-for-triage to fluent-plugin-kafka repository for this purpose: fluent/fluent-plugin-kafka@85538f6

Oh, automatically adding waiting-for-triage at opening a new issue, I see! This looks nice idea!

@ashie
GHA: Don't close untriaged or assigned issues automatically
0f1cedc 
In addition, shorten `days-before-stale` for triaged issues.

Signed-off-by: Takuro Ashie <[email protected]>
@ashie ashie marked this pull request as ready for review March 30, 2023 02:30
@ashie
Copy link
Member Author

ashie commented Mar 30, 2023

I've added same settings for fluent-plugin-kafka, and shorten days-before-stale to 30 because 90 is too long for answered issues.

daipom
daipom approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I agree.

.github/workflows/stale-actions.yml Outdated Show resolved Hide resolved
@ashie ashie force-pushed the revive-issue-auto-closer branch from 223c043 to 93a5cb2 Compare March 31, 2023 02:35
@ashie ashie merged commit 24c8bdd into master Apr 9, 2023
@ashie ashie deleted the revive-issue-auto-closer branch April 9, 2023 23:52
@ashie ashie added this to the v1.16.1 milestone Apr 13, 2023
This was referenced May 11, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daipom daipom daipom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.16.1
Development

Successfully merging this pull request may close these issues.
2 participants
@ashie @daipom